fix: preserve private source metadata and close codec boundaries - #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
go test -mod=readonly ./... -count=1passed.go test -racepassed.npm run checkpassed on unchanged82b3e1362760fc1b533a0e4b6bab839df7ada2d0with a clean worktree, including 315/315 Chromium, Firefox and WebKit tests, package artifacts, self-hosting receipts, coverage and release closeout.Scope And Limitations
The candidate remains private. This PR does not perform public source-v2 cutover, change supported platforms, establish a DSL/token-cost advantage or prove consumer adoption. Generated review results do not prove host-enforced agent isolation or an exhaustive absence of defects; those stronger campaign claims remain unverified. The previously missing instrumentation-byte review is closed by two independent reviewers, separately from native execution receipts.
Retro
Earlier review found a minimum-depth inconsistency, a wrong lexical diagnostic owner and a rejection-only test that did not observe pre-rejection copying. Their original failures were retained and the repairs were tested causally. A narrow follow-up supplied complete instrumentation variants and overlay mappings instead of relying only on logs. No installed skill was changed.
The first committed full gate stopped because the new local worktree lacked its locked TypeScript development dependency. Installing the unchanged lockfile with the declared npm version and scripts disabled restored the prerequisite; the complete gate then passed without a source change. The failed attempt remains retained separately from the passing successor.