feat(editor): redesign examples app and fix bubble menu bugs#3094
Open
joaopcm wants to merge 3 commits intofeat/ai-oss-editorfrom
Open
feat(editor): redesign examples app and fix bubble menu bugs#3094joaopcm wants to merge 3 commits intofeat/ai-oss-editorfrom
joaopcm wants to merge 3 commits intofeat/ai-oss-editorfrom
Conversation
…mples Rethink the examples app from 4 flat tabs to 11 curated examples organized by difficulty (Getting Started, Intermediate, Advanced) with a fixed sidebar and hash-based routing. Editor improvements: - Fix bubble menu collision bug caused by shared pluginKey across all menus - Add excludeMarks support to BubbleMenuRoot for mark-based exclusion - Add ButtonBubbleMenu form + unlink components for editing button links - Fix LinkBubbleMenu form not syncing href on edit - Align bubble menu sizing across text, link, and button menus - Add link and button default styles to editor theme - Bump version to 0.0.0-experimental.30
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
commit: |
Member
Author
|
Auto-merge enabled (squash) via PR Sentinel. |
14600e2 to
26657e2
Compare
6 tasks
Member
Author
|
Auto-merge disabled via PR Sentinel. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the editor examples app from 4 flat tabs to 11 curated examples organized by difficulty (Getting Started → Intermediate → Advanced) with a fixed sidebar and hash-based routing (
useHashRoutehook, zero dependencies).Demo
https://www.loom.com/share/c414c564696a4318b0aa9decfb25b035
Examples app changes:
ExampleShellfor consistent layoutsections[]array drives sidebar + routing)Editor bug fixes and improvements:
pluginKey = 'bubbleMenu', causingshouldShowfunctions to cross-contaminate via tiptap'supdateOptionsmechanism. Each menu now has a unique key (textBubbleMenu,linkBubbleMenu,buttonBubbleMenu,imageBubbleMenu)excludeMarkstoBubbleMenuRoot: allows hiding text bubble menu when a mark (likelink) is active, complementing existingexcludeNodesButtonBubbleMenuForm+ButtonBubbleMenuUnlink: button bubble menu can now edit/remove button links (pencil + unlink icons)LinkBubbleMenuFormstale input:inputValuenow syncs withdisplayHrefwhen editing starts0.375rem, icons0.875rem)Testing steps
pnpm devinpackages/editor/examplesand verify sidebar renders all 11 examplesSummary by cubic
Redesigned the
@react-email/editorexamples app into 11 curated demos with a fixed sidebar and hash-based routing. Fixed bubble menu collisions and improved link/button menus and default theming.New Features
useHashRoute,ExampleShell, and a registry-drivensections[](Getting Started → Intermediate → Advanced) covering: Basic Editor, Bubble Menu, Slash Commands, Custom Bubble Menu, Link Editing, Column Layouts, Buttons, Email Theming, Email Export, Custom Extensions, Full Email Builder.excludeMarkstoBubbleMenu.Root/BubbleMenu.Default,excludeNodesnow checks ancestors; unified menu padding (0.375rem) and icon size (0.875rem); added default link and button theme styles.validateUrl,onLinkApply,onLinkRemove, plus unlink action; edit icon switched to pencil and unlink shows only when a link exists.Bug Fixes
pluginKeys:textBubbleMenu,linkBubbleMenu,buttonBubbleMenu,imageBubbleMenu.displayHrefwhen editing starts and removes the double border.shouldShowsignature and button menu behavior.Written for commit 26657e2. Summary will update on new commits.