Merged
Conversation
Contributor
There was a problem hiding this comment.
8 issues found across 14 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/commands/domains/utils.ts">
<violation number="1" location="src/commands/domains/utils.ts:22">
P2: The DNS card separator is fixed-width and can still overflow on narrow terminals.</violation>
<violation number="2" location="src/commands/domains/utils.ts:38">
P3: The new `renderTable` column-options argument is currently unused, so this added config is dead code.</violation>
</file>
<file name="src/commands/contacts/utils.ts">
<violation number="1" location="src/commands/contacts/utils.ts:28">
P2: The added column config is currently a no-op because `renderTable` ignores its `_columns` argument, so the overflow fix is not applied.</violation>
</file>
<file name="src/commands/webhooks/utils.ts">
<violation number="1" location="src/commands/webhooks/utils.ts:42">
P2: This added column config is currently a no-op because `renderTable` ignores its `_columns` parameter, so the overflow fix is not actually applied.</violation>
</file>
<file name="src/commands/contact-properties/utils.ts">
<violation number="1" location="src/commands/contact-properties/utils.ts:16">
P2: This new column-options argument is currently ignored by `renderTable`, so `{ fixed: true }` does not affect layout/overflow and the intended fix is not applied.</violation>
</file>
<file name="src/commands/broadcasts/utils.ts">
<violation number="1" location="src/commands/broadcasts/utils.ts:34">
P2: The new column config is ignored by `renderTable`, so this change does not actually affect table overflow behavior.</violation>
</file>
<file name="src/commands/api-keys/utils.ts">
<violation number="1" location="src/commands/api-keys/utils.ts:7">
P2: The added column options are currently ignored by `renderTable`, so this change does not affect layout behavior and introduces no-op config.</violation>
</file>
<file name="src/commands/segments/utils.ts">
<violation number="1" location="src/commands/segments/utils.ts:6">
P2: The new column config is ignored because `renderTable` does not use its `_columns` parameter, so this change does not actually affect overflow/layout.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
vcapretz
approved these changes
Mar 21, 2026
renderTable now detects terminal width and either proportionally shrinks columns or switches to a vertical card layout when columns would become too narrow to be useful (below 12 chars). ID columns are marked as fixed to prevent truncation. When piped, tables render at full natural width.
Columns already below MIN_USEFUL_WIDTH (like Status at ~9 chars) were triggering card mode at normal terminal widths. Now only columns that were wide enough but got crushed below the threshold trigger the card fallback.
…overflows Instead of proportionally shrinking columns with "..." truncation (which still produces unreadable output), simply switch to the card layout whenever the table doesn't fit the terminal width. Table renders at full natural width or cards — no middle ground.
The columns/fixed parameter was only needed for the truncation logic, which has been removed in favor of the card fallback. All callers reverted to the original 3-arg renderTable signature.
e3a76c7 to
7252cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a card layout for long outputs and for narrow terminals.