fix(Flyout): fix hover reliability across gap, safe area, and race conditions#598
Draft
egucciar wants to merge 1 commit intoreshaped-ui:canaryfrom
Draft
fix(Flyout): fix hover reliability across gap, safe area, and race conditions#598egucciar wants to merge 1 commit intoreshaped-ui:canaryfrom
egucciar wants to merge 1 commit intoreshaped-ui:canaryfrom
Conversation
egucciar
force-pushed
the
flyout-fix-hover-edge-cases
branch
from
c11453c to
fd3bb1d
Compare
egucciar
changed the title
…nditions - Adjust hover timing: instant open (0ms), 200ms leave grace period - Expand safe area polygon with trough rect and content rect checks - Add 50ms grace period to prevent single mousemove closing the menu - Remove disableTriggers/enableTriggers (broke adjacent hover menus) - Add openIntentRef to handle async render race condition - Clean up safe area on content mouse enter to prevent racing - Read safe area origin before cleanup to prevent data loss
egucciar
force-pushed
the
flyout-fix-hover-edge-cases
branch
from
fd3bb1d to
91c9497
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Screenshots / Recordings
Notes for Reviewers