fix: correct x86 32-bit AVX/AVX2 intrinsic imports - #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core::arch::x86_64doesn't exist on 32-bitx86targets.'Several SIMD helper functions gated with
#[cfg(any(target_arch = "x86", target_arch = "x86_64"))](so theycompile on both 32- and 64-bit x86) unconditionally did
use core::arch::x86_64::*;inside the function body, which fails tocompile on 32-bit x86 targets
this broke the Android x86 (32-bit)
build.
This switches those imports to pull from
core::arch::x86orcore::arch::x86_64depending on the actual compile target.core::arch::x86andcore::arch::x86_64expose identical intrinsicnames for the SSE/AVX/AVX2/FMA ops used here, so no logic changes
Verified: CI build for Android x86 (32-bit) now succeeds in my fork