refactor: get rid of umbrella - #51
Merged
Merged
Conversation
revolko
force-pushed
the
refactor/integrate-boundary
branch
4 times, most recently
from
September 20, 2025 20:07
b6f17a0 to
1e9b73d
Compare
Owner
Author
|
TODO:
|
Umbrella is suitable for projects that compile only certain applications when releasing. Even though it may seem that dbreplex is such project, it is not. Every release will contian all publishers/subscribers. Another reasons for switching from the umbrella structure are nicely summarized here: https://elixirforum.com/t/migrating-off-of-an-umbrella-app-structure/53735/6
And move pgsubscriber in the new folder.
And move FilePublisher to the new folder.
revolko
force-pushed
the
refactor/integrate-boundary
branch
from
September 29, 2025 19:07
acde03c to
ecc6fe8
Compare
revolko
marked this pull request as ready for review
September 29, 2025 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Umbrella is suitable for projects that compile only certain applications when releasing. Even though it may seem that dbreplex is such project, it is not. Every release will contian all publishers/subscribers.
Another reasons for switching from the umbrella structure are nicely summarized here:
https://elixirforum.com/t/migrating-off-of-an-umbrella-app-structure/53735/6