Skip to content
This repository was archived by the owner on Jul 27, 2023. It is now read-only.

Fix breaking test and upgrade TestContainers for M1 support#472

Open
dlabey wants to merge 2 commits intorickfast:masterfrom
dlabey:fix-build-update-testcontainers
Open

Fix breaking test and upgrade TestContainers for M1 support#472
dlabey wants to merge 2 commits intorickfast:masterfrom
dlabey:fix-build-update-testcontainers

Conversation

@dlabey
Copy link

@dlabey dlabey commented Jan 24, 2023

  • shouldGetNodeInCallback() in CatalogITest was using createAutoDeregisterServiceId() which adds to the list of agent registered services which is attempted to be deregistered in cleanup. The /catalog/services endpoint returns an aggregated list of services registered with each agent across the data center. The /agent/services endpoint will only return services registered against the specific local agent with which you are communicating. This test was not reliable in this regard as the registered catalog service was not found in the agent list of registered services and erroring.
  • Upgraded testcontainers.version from 1.15.1 to 1.17.6 so M1 support exists

@dlabey
Copy link
Author

dlabey commented Jan 25, 2023

@rickfast can you look at this and run this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant