Skip to content

Show Hyper on top of fullscreen apps#31

Open
iammenasco wants to merge 1 commit into
rickgbw:masterfrom
iammenasco:fullscreen-fix
Open

Show Hyper on top of fullscreen apps#31
iammenasco wants to merge 1 commit into
rickgbw:masterfrom
iammenasco:fullscreen-fix

Conversation

@iammenasco
Copy link
Copy Markdown

Setting win.setAlwaysOnTop to true is not enough to allow Hyper to show up on top of full screen apps. We need to pass in the optional 'level' parameter.

@rickgbw
Copy link
Copy Markdown
Owner

rickgbw commented May 5, 2017

Looking at BrowserWindow docs, the screen (only) parameter not exists for setAlwaysOnTop.
https://electron.atom.io/docs/api/browser-window/#winsetalwaysontopflag-level-relativelevel

@mattapperson
Copy link
Copy Markdown

Bump! Would really love to see this!

@mattapperson
Copy link
Copy Markdown

FWIW I will gladly help make any needed changes to get this merged

@iammenasco
Copy link
Copy Markdown
Author

I read an article that said passing screen would do the trick, but looks like its not on the official  documentation. I haven't been able to look into other parameters that would accomplish this, though it seemed to be fine during development...

@shadyvb
Copy link
Copy Markdown

shadyvb commented Apr 21, 2018

FWIW The following fixed it for me:

if ( this._config.alwaysOnTop && ! this._config.primaryDisplay ) {
	this._app.dock.hide();
	win.setVisibleOnAllWorkspaces(true);
	win.setFullScreenable(false);
}

@jcristol
Copy link
Copy Markdown

@shadyvb I made this fix to my overlay.js. However, there is a small gap between the top of the screen and the top of the hyper window when using hyper-overlay over a full screen app. The gap size is the same size of the topbar in osx. Is their a way to conditionally push up the hyper window when displaying it over fullscreen apps?

@shadyvb
Copy link
Copy Markdown

shadyvb commented Jul 25, 2018

Unfortunately I've been having the same, and it even extends to the first line or two in the terminal, very annoying when you try copying stuff from those first couple of lines. A small price to pay to get all the awesomeness I guess!

@jcristol
Copy link
Copy Markdown

It was bothering me so I pinned the hyper window to the bottom of my screen. No top bar to contend with.

@shadyvb
Copy link
Copy Markdown

shadyvb commented Jul 26, 2018

Nice! Never thought of that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants