refac: make admin network errors recoverable when cached data exists#9526
Open
djbarnwal wants to merge 1 commit into
Open
refac: make admin network errors recoverable when cached data exists#9526djbarnwal wants to merge 1 commit into
djbarnwal wants to merge 1 commit into
Conversation
AdityaHegde
requested changes
Jun 5, 2026
| let adminNetworkErrorActive = false; | ||
|
|
||
| export function isNetworkError(error: unknown): boolean { | ||
| return error instanceof Error && error.message === AdminNetworkErrorMessage; |
Collaborator
There was a problem hiding this comment.
Does this handle all cases? Check web-common/src/lib/errors.ts for some additional types of errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning to an already-open dashboard tab frequently shows a full-page “Network Error” instead of either preserving the last view or retrying the load.
Root cause: any admin API query failing with Axios’
Network Errorwas treated as a global fatal error. This could happen from background or peripheral admin queries, even when the dashboard already had usable cached data. Once set, the global error page only cleared on navigation, so the tab could remain stuck on the network error.This change:
Network Erroroccurs but the query already has cached dataonline, focus, and tab visibility recoveryNetwork Errorquery failures