Performance

[ThomasJunk]

Proposal of using vars to serialize an objects instance instead of hopping over SQL-Alchemy propertier. From the first sight it seams to do the trick. Perhaps you should take this into consideration or maybe tweak it a little bit to suit your needs.
Overall it brought 0.5s (on my laptop) which could matter.

32fb517

is only relevant

[ThomasJunk]

Note to the failing test: There could be a filtering implemented to clean the exports of unnecessary fields. The general serialization would be improved. So the cost of a filter is low.

[toirl]

You mean 0,5 secs per call of get_values? Or 0,5 sec in total of a more complex request? So what is the estimated gain per call?

[ThomasJunk]

To put it in a more general context:
To retrieve (many/all) values from a SQLAlchemy object, I found it cheaper to read from its __dict__ (via vars()) than to use the dotnotation.

Measurably it increased the performance for 2k full fledged Instances of Businessobjects with several dependend Objects (which add up to about 8k-10k) Objects.

If you read only the ready resultset, this is the faster way.

It comes at the cost, that you perhaps get more than you intended.

[ThomasJunk]

But as I said, this is in draft stage and proposed for further consideration.

[toirl]

Yes. I appreciate the performance gain! Let's see how to make it generally usable. As you said this proposal is missing some filtering. "vars" simply returns the __dict__ of the item. This may include more than needed/wanted, so filtering is needed. Unfortunately I am not aware of a better way to filter relations and columns from the item than using the helper methods in /lib/alembic.py, which are the ones which make the call expensive. Do you? Thomas Junk <notifications@github.com> schrieb am Di., 29. Aug. 2017 um 09:11 Uhr:

…

But as I said, this is in *draft* stage and proposed for further consideration. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#88 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADjgDIX8O1O8x_EFVlcA0AgvvoGHZi6-ks5sc7mcgaJpZM4PDZrg> .