Open
Conversation
potrue
reviewed
May 22, 2025
|
|
||
| for num in nums: | ||
| cumsum += num | ||
| if cumsum - k in cumsum_to_count: |
There was a problem hiding this comment.
defaultdictを使うのであればこの条件分岐はなくてもいいかもしれません。
(defaultdictは評価された時点で辞書の中に値が入るので、条件分岐をしておくと無駄に辞書の中身が増えないという利点はありますが)
nktr-cp
reviewed
May 22, 2025
| num_subarrays = 0 | ||
| cumsum = 0 | ||
| cumsum_to_count = defaultdict(int) | ||
| cumsum_to_count[0] = 1 |
There was a problem hiding this comment.
多分好みの問題なのですが，自分はここはcumsum_to_count[cumsum] = 1が嬉しいです
| complement = k - nums[i] | ||
| if complement == 0: | ||
| num_subarrays += 1 | ||
| for j in range(i+1, len(nums)): |
tokuhirat
reviewed
May 22, 2025
| cumsum_to_count[cumsum] += 1 | ||
|
|
||
| return num_subarrays | ||
| ``` |
oda
reviewed
May 23, 2025
|
|
||
| - https://github.com/potrue/leetcode/pull/16/files?short_path=9af6c29#diff-9af6c29cdcdd4f79ab8b011317151f6cd8b13f570a036eb4d7473388bc3f0d56 | ||
| - chainを使って解いているがchainについて初めて見たので[ドキュメント]()https://docs.python.org/ja/3.13/library/itertools.html#itertools.chainを見る | ||
|
|
There was a problem hiding this comment.
ドキュメントを読むのはいい癖だと思います。
それから読む先ですが完走者の中で気に入った人を見繕っておいてもいいかと思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.