Conversation
Builds riscv64 wheels for qdldl 0.1.9.post1 (the LDL' factorization solver used by the already-merged osqp package), following the build-from-checkout shape used by build-osqp.yml/build-fonttools.yml. The C library is vendored as a git submodule rather than FetchContent (unlike osqp's own C core), so the checkout step needs submodules: true instead. Includes a patch to package the vendored AMD ordering library's BSD-3-Clause licence alongside qdldl-python's own Apache-2.0 LICENSE, mirroring the osqp/osqp-python licensing fix for the same underlying AMD dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qdldl0.1.9.post1Compiles a pybind11/CMake extension around the QDLDL C library and its vendored AMD ordering routine. Upstream publishes no riscv64 wheel.
Mirrors upstream's
build.yml.Differs from upstream
submodules: trueonly, no macOS/Windows matrix, no Cython-freethreading flag - riscv64 is Linux-only and cibuildwheel enables the target directly viaonly:.Testing
pytest tests), plus asserting the licence fix below stays packaged.License: Wheel bundles AMD (BSD-3-Clause, vendored from SuiteSparse) statically linked into
libqdldlamd.a; upstream's own wheels omit its licence text, so the patch adds it.Patches
0001-Package-the-vendored-AMD-ordering-library-s-licence.patch- To upstream [not yet submitted]. Without it the wheel ships AMD's object code with no BSD-3-Clause notice. Reproduces on any arch, not riscv64-only.Built on cp312; 9 passed.