Conversation
Cython statistics library (t-digest, summary stats) with a numpy build-time dependency. Backports two small upstream fixes (sequence point, type-punning) that landed on main after the 0.0.8 tag but before any release.
Neither cp314 nor cp314t is upstream-supported (tests.yml stops at 3.13, no free-threaded env or classifiers); cp314 segfaults building a crick object during test collection and cp314t's test_object_reference_counting fails because free-threaded CPython's immortal objects break sys.getrefcount() arithmetic -- both unrelated to riscv64. Also fix the wheel-contents check: the licenses/ directory entry itself matched the .dist-info/licenses/ glob and rsplit to an empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crick0.0.8Compiles crick's t-digest, space-saving, and summary-stats Cython extensions against numpy's C API into a wheel. Upstream publishes no riscv64 wheel.
Mirrors upstream's
wheels.yml.Differs from upstream
Matrix: cp310-cp313, no cp314/cp314t - upstream's own CI (and
requires-python) covers only 3.10-3.13; cp314 segfaults building a crick object during test collection and cp314t'stest_object_reference_countingfails because free-threaded CPython's immortal objects break plainsys.getrefcount()arithmetic, both unrelated to riscv64.Testing
CIBW_TEST_REQUIRES- crick doesn't declare it as a runtime dependency even though the compiled extensions call numpy's C API at import time.License: OK
Patches
0001-Fix-sequence-point-error-in-stats_kurt.patch- Backport dask/crick@720de70c. Redundant self-assignment flagged as undefined behaviour by strict compilers; reproduces off riscv64 too.0002-Avoid-dereferencing-a-type-punned-pointer-in-asint64.patch- Backport dask/crick@70d9dc24. Strict-aliasing violation that can miscompile under -O2/-O3; reproduces off riscv64 too. Both landed on upstreammainafter the0.0.8tag; no release contains them yet.Built on cp312; 69 passed, 30 skipped.