fix: derive ECDSA public key from private key correctly#6
Open
script3r wants to merge 1 commit intorishabhyadavv:mainfrom
Open
fix: derive ECDSA public key from private key correctly#6script3r wants to merge 1 commit intorishabhyadavv:mainfrom
script3r wants to merge 1 commit intorishabhyadavv:mainfrom
Conversation
The getPublicECDSAKey function was generating a random key pair instead of deriving the public key from the provided private key. This meant every call returned a different random public key. Fixed by implementing proper EC point multiplication (Q = d × G) using the double-and-add algorithm to derive the public key deterministically. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
getPublicECDSAKeyon Android was generating a random key pair instead of deriving the public key from the provided private key:This meant every call returned a different random public key, breaking signature verification.
Fix
Replaced with proper EC point multiplication (
Q = d × G) using the double-and-add algorithm to derive the public key deterministically from the private key scalar.Also added JUnit test dependencies and a unit test to verify the fix.