Skip to content

feat(ci): improve iOS build caching for test harness #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfazekas merged 1 commit into from
Jan 21, 2026
Merged

feat(ci): improve iOS build caching for test harness #126

mfazekas merged 1 commit into from
Jan 21, 2026

Conversation

@mfazekas
Copy link
Collaborator

@mfazekas mfazekas commented Jan 19, 2026 •
edited
Loading

Summary

  • Cache Xcode build artifacts in test-harness-ios job, skipping xcodebuild when only JS files change
  • Update turbo inputs to only track src/specs/*.nitro.ts instead of all TS files

Test plan

  • Verify CI passes on first run (cache miss, full build)
  • Verify subsequent JS-only changes skip native build (cache hit)

@mfazekas mfazekas force-pushed the feat/ios-build-caching branch 3 times, most recently from 7fe0ecc to 5097887 Compare January 20, 2026 13:27
@mfazekas mfazekas marked this pull request as ready for review January 20, 2026 16:53
@mfazekas mfazekas force-pushed the feat/ios-build-caching branch from 5097887 to e0aa787 Compare January 20, 2026 16:53
@mfazekas mfazekas requested a review from HayesGordon January 20, 2026 16:53
HayesGordon
HayesGordon approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@HayesGordon HayesGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfazekas mfazekas enabled auto-merge (squash) January 21, 2026 20:34
@mfazekas
feat(ci): improve iOS build caching for test harness
0d3296e 
- Cache Xcode build artifacts in test-harness-ios job
- Skip xcodebuild when cache hits (JS-only changes)
- Update turbo inputs to only track nitro specs, not all TS files
- Remove yarn.lock from native build cache keys
@mfazekas mfazekas force-pushed the feat/ios-build-caching branch from e0aa787 to 0d3296e Compare January 21, 2026 20:34
@mfazekas mfazekas merged commit fd22bb3 into main Jan 21, 2026
7 of 8 checks passed
@mfazekas mfazekas deleted the feat/ios-build-caching branch January 21, 2026 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HayesGordon HayesGordon HayesGordon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfazekas @HayesGordon