Add JobStuckHandler callback#1291
Open
brandur wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Here, add a `JobStuckHandler` callback that's invoked when a producer consider a job to be "stuck". i.e. Passed its timeout, cancellation attempted, but job didn't respond to cancellation. The callback includes some basic information about the job that became stuck, along with the total number of stuck jobs. A result will optionally open a new executor slot to replace the one taken up by the stuck job so that a producer that continues to be run doesn't get completed starved by stuck jobs. The idea here is that clients can configure themselves to open new slots up to a certain point, but then may want to restart themselves if there's enough jobs stuck that they could become a memory liability.
brandur
force-pushed
the
brandur-stuck-job-handler
branch
from
098d829 to
93b3691
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, add a
JobStuckHandlercallback that's invoked when a producerconsider a job to be "stuck". i.e. Passed its timeout, cancellation
attempted, but job didn't respond to cancellation.
The callback includes some basic information about the job that became
stuck, along with the total number of stuck jobs. A result will
optionally open a new executor slot to replace the one taken up by the
stuck job so that a producer that continues to be run doesn't get
completed starved by stuck jobs. The idea here is that clients can
configure themselves to open new slots up to a certain point, but then
may want to restart themselves if there's enough jobs stuck that they
could become a memory liability.