feat: add ability to filter jobs by tags#548
feat: add ability to filter jobs by tags#548golanglemonade wants to merge 2 commits intoriverqueue:masterfrom
Conversation
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brandur
left a comment
There was a problem hiding this comment.
Thanks @golanglemonade! Thoughts on autocomplete for tag names? A bit harder maybe than queue names or job kinds, but seems like it'd be make the feature a lot more useful.
|
|
||
| default: | ||
| return nil, apierror.NewBadRequestf("Invalid facet %q. Valid facets are: job_kind, queue_name", req.Facet) | ||
| default: |
There was a problem hiding this comment.
Think this whitespace is wrong and should go back to how it was before.
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
Yep, I actually had a working automcomplete, but required direct sql because the riverdrver doesn't support the query, but I figured the preferred path would be to query the riverdriver with the update and then come back and add auto complete here? |
|
Ah nice. Yeah, there won't be a drive function for that. @bgentry We better get your input before @golanglemonade goes too much further with this one. Is there a reason this feature didn't exist in the beginning, or just was never implemented? |
We have a lot of jobs with the same kind, but different tags. This will make it much easier to filter the data and find jobs.