fix(pi): keep appended prompts out of path resolution#1651
Draft
NathanFlurry wants to merge 1 commit into
Draft
Conversation
|
🚅 Deployed to the agentos-pr-1651 environment in agentos
🚅 Environment agentos-pr-1651 in rivet-frontend has no services deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1650.
What changed
appendSystemPromptOverridewhen extensions requireDefaultResourceLoader.appendSystemPromptoption.createSession("pi").Why
When any Pi extension was present, the adapter switched from
MinimalResourceLoaderto Pi'sDefaultResourceLoader. Passing the OS/tool instructions asappendSystemPromptcaused Pi to check whether that long text existed as a filesystem path, triggeringFile name too longduringsession/new.Validation
pnpm --filter @agentos-software/pi check-typespnpm --filter @agentos-software/pi testAGENTOS_E2E_FULL=1 pnpm --dir packages/core exec vitest run tests/pi-extensions.test.ts --reporter=verbosepnpm exec biome check registry/agent/pi/src/adapter.ts registry/agent/pi/tests/adapter.test.mjs packages/core/tests/pi-extensions.test.tsnode scripts/verify-fixed-versions.mjs