Repository navigation
feat: add opt-in Precognition support to ParseRequest - #26
Merged
Merged
Conversation
Endpoints enable ParseOptions.Precognition; requests with the "Precognition: true" header run decoding, path binding and validation, then stop: 204 No Content on success (ParseRequest returns ErrPrecognitionHandled), 422 with the validator's problem on failure. Parse errors keep their usual 400/413 responses. Closes #20 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FHBdej3KvFACHzafbEhw7C
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 7
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 86.27% 87.39% +1.11%
==========================================
Files 14 15 +1
Lines 583 603 +20
==========================================
+ Hits 503 527 +24
+ Misses 62 58 -4
Partials 18 18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
API
ParseOptions.Precognition bool— per-endpoint opt-in. When false, the header is ignored (request processed normally).Precognition: true.IsPrecognitionRequest(r)exposes the check.ErrPrecognitionHandledsentinel +IsPrecognitionHandled(err).Behavior (opted-in + header)
Same pipeline as today (decode → bind path params → validate), then stop:
err204 No Content,Precognition-Success: trueErrPrecognitionHandled422, validator'sProblemDetails(extensions kept)400/413Opted-in endpoints also add
Vary: Precognition.Business logic can't run: a successful precognitive request returns a non-nil error, so the existing
if err != nil { return }pattern stops the handler. No change for current callers.Also
examples/restapiPOST /usersopts in.go vet,go test -race ./..., validation/playground and examples tests pass locally.Generated by Claude Code
Summary by CodeRabbit
Varyheader; requests without the option continue through normal handling.