fix(types,http-action): align vendored SDK type and http-action floor with core - #48
Merged
Merged
Conversation
…loor with core
Two low-severity contract-drift fixes against core 0.10.10.
types/openwa.d.ts: add the two HookEvents core dispatches that the vendored
SDK type omitted — message:persisted and ingress:error. A plugin that wrote
ctx.registerHook('message:persisted', …) against this type got a TypeScript
error even though the host would accept and dispatch it; the runtime allowed
what the type forbade. The type now mirrors core's HookEvent union (19 events).
http-action: minOpenWAVersion 0.8.7 → 0.8.0. The two capabilities http-action
relies on — conversation:send and net.allowConfigHosts — both shipped in
0.8.0 (the Integration Fabric release). The 0.8.7 floor was overstated by
seven patch versions, refusing an install on servers that would in fact run
the plugin correctly. Widening compatibility, not a behaviour change — no
version bump.
plugins.json + http-action/README regenerated by `npm run catalog` so the
catalog and the manifest stay in sync (the catalog:check CI gate).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two low-severity contract-drift fixes against core
0.10.10.Changes
types/openwa.d.ts— add the two missing HookEventsThe vendored plugin SDK type omitted
message:persistedandingress:error, both of which core dispatches (19 events total). A plugin that wrotectx.registerHook('message:persisted', …)against this type got a TypeScript error even though the host accepts and dispatches it — the runtime allowed what the type forbade. The type now mirrors core'sHookEventunion.http-action/manifest.json—minOpenWAVersion0.8.7 → 0.8.0The two capabilities http-action relies on —
conversation:sendandnet.allowConfigHosts— both shipped in 0.8.0 (the Integration Fabric release, per core CHANGELOG). The 0.8.7 floor was overstated by seven patch versions, refusing an install on servers that would in fact run the plugin correctly. Widening compatibility, not a behaviour change — no version bump.Regenerated artifacts
plugins.jsonandhttp-action/README.mdregenerated bynpm run catalogso the catalog and the manifest stay in sync (thecatalog:checkCI gate).Verification
npm run typecheckclean.npm run catalog:check— "Catalog up to date".npm test— 435/435 pass.Notes
hook.interfaces.tsat release time; this PR removes the drift today.http-actionisbetawith notestedOpenWAVersion, so widening the floor is low-risk — operators on 0.8.0+ who were previously refused can now install.