Skip to content

fix: support React Native 0.87 LayoutMetrics on iOS - #4295

Open
Preeternal wants to merge 1 commit into
rnmapbox:mainfrom
Preeternal:fix-rn-0.87-ios-layout-metrics
Open

fix: support React Native 0.87 LayoutMetrics on iOS#4295
Preeternal wants to merge 1 commit into
rnmapbox:mainfrom
Preeternal:fix-rn-0.87-ios-layout-metrics

Conversation

@Preeternal

Copy link
Copy Markdown

Description

Fixes an iOS build failure with React Native 0.87.

React Native 0.87 added fontSizeMultiplier to LayoutMetrics, between pointScaleFactor and overflowInset.

RNMBXMarkerViewComponentView constructs LayoutMetrics positionally, so without this field overflowInset is passed into the wrong slot and the build fails with:

No viable conversion from 'const EdgeInsets'

This adds the missing fontSizeMultiplier field to the initializer.

Tested with:

  • React Native 0.87.1
  • New Architecture
  • iOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant