chore: restore the debug build tag in CI - #103
Merged
Merged
Conversation
roadrunner-server/errors gates stack capture on the debug tag: debug_cap.go is !debug and stubs populateStack/printStack out, while debug_stack.go captures the caller chain and prints file:line per frame. Without the tag a CI failure shows a bare error string instead of the call chain.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
=======================================
Coverage 97.82% 97.82%
=======================================
Files 3 3
Lines 184 184
=======================================
Hits 180 180
Misses 3 3
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-tags=debugwas dropped from the test commands here. It is not inert.roadrunner-server/errorssplits on the tag —debug_cap.gois//go:build !debugand makespopulateStack/printStackno-ops, whiledebug_stack.gocaptures the caller chain, coalesces frames shared between wrapped errors, and printsfile:line: funcfor each. Without the tag a CI failure shows a bare error string instead of the call chain that makes it readable.Restores the tag on both test steps. Verified
go test -tags=debug ./...passes locally.