Skip to content

Enable different request for frc in subscriptions#45

Open
roanutil wants to merge 3 commits intomainfrom
enable-different-request-for-frc-in-subscriptions
Open

Enable different request for frc in subscriptions#45
roanutil wants to merge 3 commits intomainfrom
enable-different-request-for-frc-in-subscriptions

Conversation

@roanutil
Copy link
Owner

There are cases where change tracking can't work with the full predicate used for fetching. We've run into an instance of that with Align. Allowing different predicates for fetching and change tracking is the best way forward.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 92.61672% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.29%. Comparing base (e5ec1cc) to head (05c01ab).

Files with missing lines Patch % Lines
Tests/CoreDataRepositoryTests/AggregateTests.swift 94.60% 30 Missing ⚠️
...ataRepository/Internal/AggregateSubscription.swift 58.82% 14 Missing ⚠️
...itory/Internal/AggregateThrowingSubscription.swift 58.82% 14 Missing ⚠️
Tests/CoreDataRepositoryTests/FetchTests.swift 93.54% 6 Missing ⚠️
...oreDataRepository/Internal/CountSubscription.swift 88.23% 2 Missing ⚠️
...epository/Internal/CountThrowingSubscription.swift 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   84.07%   85.29%   +1.22%     
==========================================
  Files          69       69              
  Lines        7654     8528     +874     
==========================================
+ Hits         6435     7274     +839     
- Misses       1219     1254      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…g and change tracking

enable-different-request-for-frc-in-subscriptions
enable-different-request-for-frc-in-subscriptions
@roanutil roanutil force-pushed the enable-different-request-for-frc-in-subscriptions branch from 459edf9 to 5b50e79 Compare February 26, 2026 18:04
enable-different-request-for-frc-in-subscriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants