Make tuning tests for OpenMP independent of platforms#432
Open
Make tuning tests for OpenMP independent of platforms#432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
test_auto_fission_fuse.py::test_tune_fuseandtest_auto_fission_fuse.py::test_tune_fission, I compare two candidate scheduling plans during the test run, and use the comparing result to check our tuner, instead of expecting a preset result. I did not apply this change to the CUDA testtest_auto_fission_fuse.py::test_tune_with_condyet, because it has 4 different types of candidate plans.To make things work, I also restart OpenMP at the beginning of timing by
omp_pause_resource_all. It works, but I am not sure how the running time of OpenMP is affected. If not restarting OpenMP, every timing runs all returned a low stddev, but time from different runs differed greatly. It worth noting thatomp_pause_resource_allis only available since OpenMP 5.0, which makes use impossible to use it from PyTorch's OpenMP 4.0, required by #421.With the above changes, I removed the
OMP_PROC_BINDmagic set by #266.