Skip to content

Bitarray Library #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FaridManafov wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Bitarray Library #29

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b8fa66
implemented bit array interface with a setall method and constructor
Aug 7, 2020
4e3d527
finished set and get, did not put any throw conditions
Aug 7, 2020
db15336
added error exceptions and error messages
Aug 7, 2020
97929fb
cleanup
Aug 7, 2020
faa86dd
more cleanup
Aug 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions bitarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
class bitarray:

def __init__(self, size):
self.arr = [0] * size

@amackillop amackillop Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a__str__ and __repr__ as a good practice. https://docs.python.org/3.8/reference/datamodel.html#object.__str__


def setall(self, bit):

@anarmanafov1 anarmanafov1 Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knit pick. Remove these empty lines.

if bit == 0 or bit == 1:
for i in range(len(self.arr)):
self.arr[i] = bit

@amackillop amackillop Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since everything is the same bit, it's probably faster to just do self.arr = [bit] * len(self.arr) again.

else:
raise Exception("SetAll: Invalid bit entered, only 1 or 0 are valid inputs.")

@amackillop amackillop Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend raising specific exceptions when it makes sense. This seems to be a ValueError, you can reference the builtin exceptions here: https://docs.python.org/3/library/exceptions.html#ValueError



def set(self, n, bit):

if bit == 0 or bit == 1:

try:
self.arr[n] = bit
except IndexError:
raise Exception("Set: Value entered is out of range of the array.")
except TypeError:
raise Exception("Set: Enter a value that is an integer")

@FaridManafov FaridManafov Aug 7, 2020

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to add generic exceptions here

@amackillop amackillop Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to just re-raise the same type of exceptions here if you want to add this information. You should also specify which value was incorrect as it's not clear what exactly went wrong from the message alone.


else:
raise Exception("Set: Invalid bit entered, only 1 or 0 are valid inputs.")



def get(self, n):

try:
return self.arr[n]
except IndexError:
raise Exception("Get: Value entered is out of range of the array.")
except TypeError:
raise Exception("Get: Value entered is not an integer.")

@amackillop amackillop Aug 8, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, re-raise the same error. Also I don't think it's necessary to mention which method in the exception message. We will already know that from the stacktrace.