CI: run Java bots on Java 25; set the exec bit in the test helper - #10
Merged
Merged
Conversation
- validate.yml and publish-catalog.yml set up Temurin 25 before the smoke check. Without it the runner's default Java 17 ran the Java bots, which breaks bots that use Java 22+ multi-file source launch as the Rumble does. - add_java_bot now marks its .sh executable. The validator has required the bit since c043c77, so two integration tests failed on POSIX; no validate run had exercised them since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI problems surfaced in #9 (Retcon 0.2.0). Neither is specific to that bot.
validate.ymlandpublish-catalog.ymlnow set up Temurin 25.add_java_botwrote its.shwithout the executable bit. The validator has required that bit since c043c77, sotest_RBC004_IntegrationPositive_a_team_may_span_two_platformsandtest_RBC004_IntegrationNegative_duplicate_bot_names_across_platforms_are_rejectedfail on POSIX. No validate run had covered them since 4 September. On Windows the check is skipped, so they pass there.Local run in a clean checkout:
Ran 14 tests ... OK (skipped=1). On Windows the POSIX-only test is skipped, so this PR's own CI run is the first Linux check.🤖 Generated with Claude Code