Repository navigation
Pin inference-models to ==0.39.0rc2 so main stops floating onto branch-published rcs - #3068
Conversation
…h-published rcs `inference-models 0.39.0rc3` was published to PyPI today (10:48 UTC) from the feat/new-model-manager branch (PR #2251). main's requirement files pinned `~=0.39.0rc2`, and a pre-release lower bound lets the resolver take any newer rc, so every image built since installs rc3. rc3 changes the SAM3 output contract (default `mask_format="rle"`, dict results) and main's adapters in inference/models/sam3/ still expect tensors, which is why "Code Quality & Regression Tests - NVIDIA T4" fails in the SAM3 step with HTTP 500 (run 36145992322). Exact-pin all five requirement files to 0.39.0rc2, the version the last green image installed. No code change; the pin is lifted by the PR that adopts the new inference-models contract. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
|
Skills: review-packaging-ci, review-topic-backward-compat-and-versioning, review-topic-test-hygiene Reviewed the pin tightening
No blocking findings and no open questions. Reviewed at HEAD: cd382be |
|
😎 PR passes the vibe-check and trust-me-bro verification. |
|
Maintainer review discussion: Slack thread. Final approval and merge remain in GitHub. |
What does this PR do?
Exact-pins
inference-modelsto0.39.0rc2in the five requirement files that previously carried~=0.39.0rc2, somainstops floating onto pre-releases published from feature branches.Why
inference-models 0.39.0rc3landed on PyPI today at 10:48 UTC, published by workflow_dispatch fromfeat/new-model-manager(#2251).~=0.39.0rc2means>=0.39.0rc2,==0.39.*, and a pre-release lower bound makes uv/pip accept any newer rc, so every image built since then installs rc3. The repo's owninference_models/source is never installed into the images (the lock root is a virtual project), the package always comes from PyPI through this pin.rc3 changes the SAM3 output contract (
segment_with_visual_promptsgainedmask_formatdefaulting to"rle"and returns dicts;segment_with_text_promptsflipped its default from dense to RLE). The adapters onmain(inference/models/sam3/*_inference_models.py) still expect tensors, which is why Code Quality & Regression Tests - NVIDIA T4 (build (true)) fails in the SAM3 step with HTTP 500: https://github.com/roboflow/inference/actions/runs/36145992322Comparing every installed package between the last green T4 image (08:40 UTC, 67725d3) and the failing one:
inference-modelsrc2 → rc3 is the only difference.What changes
No code change.
Dockerfile.onnx.cpu's unversionedpip3 install "inference-models[model-blob-cache]"runs after the wheel install already placed rc2 and is satisfied by it.workflows/pyproject.toml'sinference-models>=0.37.1is satisfied by the installed rc2 as well (same as it was by rc3 in the failing build).The pin is lifted by whichever PR adopts the new
inference-modelscontract (#2251 pins~=0.39.0rc3and updates the SAM3 module, but touches no file underinference/models/sam3/).Type of Change
Testing
0.39.0rc2only (rc3excluded), checked withpackaging.mainand manual dispatch, so it will not run on this PR. rc2 is the exact version the last green T4 image installed.Checklist
Additional Context
Related: #2251 (source of rc3). Follow-up worth agreeing on: branch publishes of
inference-modelsshould use.devNversions, which sort belowmain's lower bound (today's0.39.0.dev20260925publish from another branch was harmless for exactly that reason).🤖 Generated with Claude Code