Repository navigation
Fast-track CI: drop the dormant model-manager suite, refresh statuses after re-runs - #3077
Conversation
The orchestrator dispatched unit_tests_inference_model_manager_and_server.yml on every fast-track branch. That workflow is path-filtered to inference_model_manager/** and inference_server/**, which exist only on feat/new-model-manager, so it never runs on main, but workflow_dispatch ignores path filters and the run died at install with "Distribution not found at: .../inference_model_manager" (3 of 3 fast-track dispatches). Before dispatching, read each workflow's pull_request path filter as it is on the branch and skip the workflow when every literal root of the filter is absent there: a PR to main would never have started it. The skip is reported as a success status and a summary row naming the absent roots. Workflows without a path filter, with a root-level pattern, or with at least one root present are dispatched as before. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The orchestrator writes each fast-track-ci / <workflow> status once, from the attempt it waited for. A maintainer re-run of a failed suite completes outside the orchestrator, so a suite that went green on re-run kept a red status on the umbrella PR (integration_tests_workflows_x86 on #3076). Add a workflow_run listener on the same test workflows that, for a re-run attempt (run_attempt > 1) of a workflow_dispatch run on a fast-track branch, rewrites the status from that attempt. It only touches a status the orchestrator created and never checks out branch code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
👋 Thanks for the pull request! Here is how automated Claude review works here, so you spend credits (and reviewer time) wisely. 🚦 This PR is marked Ready for review, so automated Claude review will run — and every pass spends real credits. Warning 💸 The Claude reviewer bills in credits, not vibesAutomated review spins up a real agent that reads real code and spends real credits on every pass. It is glad to help — but it is not a rubber duck, a linter you poke in a loop, or a substitute for reading the contributing guide. Treat it like an expensive senior reviewer whose time you booked, and show up prepared. Draft when unsure, Ready when you mean it:
However you get there, arrive prepared:
Reviews are not free. A draft costs nothing to review; a Ready PR is a promise that it is worth reviewing.
|
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
|
Review summary — Skills: review-packaging-ci (surface), review-topic-test-hygiene (topic). Two CI-orchestrator fixes to
No user/dev-visible package contract changes → no changelog/version notice required (CI infra only). minor doubts (non-blocking): the new Reviewed at HEAD: d78dba1 |
|
😎 PR passes the vibe-check and trust-me-bro verification. |
…ing dormancy Replace the path-filter dormancy check with the plain fix: remove unit_tests_inference_model_manager_and_server.yml from TEST_WORKFLOWS, with a comment saying why and when to put it back (once inference_model_manager/ and inference_server/ land on main, #2251). The status-sync listener drops the same workflow name so the two lists stay aligned. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
🤖 Claude review started at commit New commits are not auto-reviewed. Add the |
|
Review summary — Skills: review-packaging-ci (surface), review-topic-test-hygiene (topic). Re-review of the delta since the last pass ( Verified against the code:
CI infra only — no user/dev-visible package contract change, so no changelog/version notice required. Reviewed at HEAD: 8ce6e76 |
|
😎 PR passes the vibe-check and trust-me-bro verification. |
|
Maintainer review discussion: Slack thread. Final approval and merge remain in GitHub. |
What does this PR do?
Two fixes to the fast-track CI orchestrator (
fast_track_ci.yml), found on the first real fast-track cycle (#3076):1. Stop dispatching a workflow that is dormant everywhere except
feat/new-model-manager.unit_tests_inference_model_manager_and_server.ymlis path-filtered toinference_model_manager/**andinference_server/**, which exist only on that branch (#2251); it has never run onmain.workflow_dispatchignores path filters, so the orchestrator dispatched it on every fast-track branch and it died at install withDistribution not found at: …/inference_model_manager(3 of 3 fast-track dispatches: two onpost-v1.6.2-pt2, one onpost-v1.7.2-pt1, e.g. https://github.com/roboflow/inference/actions/runs/36472734041). Fix: remove it fromTEST_WORKFLOWS, with a comment saying why and when to put it back (when #2251 lands the packages onmain). An earlier revision of this PR detected dormancy from each workflow's path filter at dispatch time; that was replaced by this plain removal (third commit).2. Refresh statuses after a re-run. The orchestrator writes each
fast-track-ci / <workflow>status once, from the attempt it waited for. A maintainer re-run completes outside it, sointegration_tests_workflows_x86stayed red on #3076 after its re-run went green (https://github.com/roboflow/inference/actions/runs/36472764699, attempt 1 failed 19:42 UTC, attempt 2 passed 20:01 UTC). Newfast_track_ci_status_sync.ymllistens withworkflow_runon the same 12 workflows and, forrun_attempt > 1of aworkflow_dispatchrun on afast-track/post-v*branch, rewrites the status from that attempt. It only refreshes a status the orchestrator created, hasstatuses: writeonly, and never checks anything out.Related: #3053 (fast-track CI), #2669 (the dormant workflow, "dormant until packages land on main"), #2251.
Type of Change
Testing
actionlintclean on both files (style-only shellcheck note SC2016 as elsewhere in the repo);.github/scripts/check_workflow_concurrency.pyOK.fast_track_ci.ymldiffers frommainonly by the removed list entry and two comments.workflow_runlistener firing on a re-run attempt. To be confirmed on the next maintainer re-run of a fast-track suite; it is inert otherwise (run_attempt > 1guard).Test details: the
workflow_runworkflows:list matches by workflow name and must be kept in sync withTEST_WORKFLOWSinfast_track_ci.yml(12 entries in both).Checklist
🤖 Generated with Claude Code