Skip to content

fix: enforce submit frequency in RocketNetworkPrices.submitPrices #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sertug17 wants to merge 1 commit into
base: master
Choose a base branch
from
+24 −0
Open

fix: enforce submit frequency in RocketNetworkPrices.submitPrices #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions contracts/contract/network/RocketNetworkPrices.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
// Constants
bytes32 immutable priceKey;
bytes32 immutable blockKey;
bytes32 immutable timestampKey;

// Events
event PricesSubmitted(address indexed from, uint256 block, uint256 slotTimestamp, uint256 rplPrice, uint256 time);
Expand All @@ -25,6 +26,7 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
// Precompute keys
priceKey = keccak256("network.prices.rpl");
blockKey = keccak256("network.prices.updated.block");
timestampKey = keccak256("network.prices.updated.timestamp");
}

/// @notice Returns the block number which prices are current for
Expand All @@ -37,6 +39,16 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
setUint(blockKey, _value);
}

/// @notice Returns the timestamp of the last price update
function getPricesTimestamp() override public view returns (uint256) {
return getUint(timestampKey);
}

/// @dev Sets the timestamp of the last price update
function setPricesTimestamp(uint256 _value) private {
setUint(timestampKey, _value);
}

/// @notice Returns the current network RPL price in ETH
function getRPLPrice() override public view returns (uint256) {
RocketNetworkSnapshotsInterface rocketNetworkSnapshots = RocketNetworkSnapshotsInterface(getContractAddress("rocketNetworkSnapshots"));
Expand Down Expand Up @@ -66,6 +78,11 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
require(_block < block.number, "Prices can not be submitted for a future block");
uint256 lastPricesBlock = getPricesBlock();
require(_block >= lastPricesBlock, "Network prices for a higher block are set");
// Check frequency
uint256 frequency = rocketDAOProtocolSettingsNetwork.getSubmitPricesFrequency();
uint256 lastTimestamp = getPricesTimestamp();
uint256 minimumTimestamp = lastTimestamp + (frequency * 95 / 100);
require(block.timestamp >= minimumTimestamp, "Price update frequency not met");
// Get submission keys
bytes32 nodeSubmissionKey = keccak256(abi.encodePacked("network.prices.submitted.node.key", msg.sender, _block, _slotTimestamp, _rplPrice));
bytes32 submissionCountKey = keccak256(abi.encodePacked("network.prices.submitted.count", _block, _slotTimestamp, _rplPrice));
Expand Down Expand Up @@ -101,6 +118,11 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
// Check block
require(_block < block.number, "Prices can not be submitted for a future block");
require(_block > getPricesBlock(), "Network prices for an equal or higher block are set");
// Check frequency
uint256 frequency = rocketDAOProtocolSettingsNetwork.getSubmitPricesFrequency();
uint256 lastTimestamp = getPricesTimestamp();
uint256 minimumTimestamp = lastTimestamp + (frequency * 95 / 100);
require(block.timestamp >= minimumTimestamp, "Price update frequency not met");
// Get submission keys
bytes32 submissionCountKey = keccak256(abi.encodePacked("network.prices.submitted.count", _block, _slotTimestamp, _rplPrice));
// Get submission count
Expand All @@ -119,6 +141,7 @@ contract RocketNetworkPrices is RocketBase, RocketNetworkPricesInterface {
// Update price
setRPLPrice(_rplPrice);
setPricesBlock(_block);
setPricesTimestamp(block.timestamp);
// Emit prices updated event
emit PricesUpdated(_block, _slotTimestamp, _rplPrice, block.timestamp);
}
Expand Down
1 change: 1 addition & 0 deletions contracts/interface/network/RocketNetworkPricesInterface.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ pragma solidity >0.5.0 <0.9.0;
// SPDX-License-Identifier: GPL-3.0-only
interface RocketNetworkPricesInterface {
function getPricesBlock() external view returns (uint256);
function getPricesTimestamp() external view returns (uint256);
function getRPLPrice() external view returns (uint256);
function submitPrices(uint256 _block, uint256 _slotTimestamp, uint256 _rplPrice) external;
function executeUpdatePrices(uint256 _block, uint256 _slotTimestamp, uint256 _rplPrice) external;
Expand Down