Add network and project_name labels to dashboard and metrics #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcabrey
force-pushed
the
prometheus-labels
branch
from
a52baf7 to
b63f24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additional labels would allow someone to distinguish between rocketpool installations when using a shared monitoring stack. For example, if you have a holesky and mainnet installation publishing to the same Prometheus/Grafana stack.
This is particularly motivated by my work on a Kubernetes native installation, where a shared monitoring stack is common. This will allow the dashboard to be shared with the Kubernetes installation (right now I have it forked with changes that make it incompatible with the Docker install).