Adding script tags for abort fetch snippet#12
Open
rhygg wants to merge 2 commits intoroeib:masterfrom
Open
Conversation
longqua69
suggested changes
Aug 18, 2021
longqua69
left a comment
longqua69
left a comment
There was a problem hiding this comment.
Your intention is good. It makes the snippet easier to understand. Removing the redundant space makes it better
README.md
Outdated
| //html | ||
| <button id="download">Download</button> | ||
| <button id="abort">Abort</button> | ||
| <button id="abort">Abort</button> |
There was a problem hiding this comment.
I think you should remove the redundant space for aligning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Since this is vanilla JS you can put it under
<script></script>tags, so that it's easier to understand what's going on. Moreover the syntax highlight for the html snippet breaks due to the syntax highlight being configured to javascript. Keeping the syntax highlight to html keeps the highlight for html and javascript intact.