-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add Azure OpenAI provider configuration #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Random-Word
wants to merge
5
commits into
rohitg00:main
Choose a base branch
from
Random-Word:feature/azure-openai-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fdd8cb8
Add Azure OpenAI provider configuration
18763de
Support GPT-5 token limits for OpenAI-compatible chat
a5dbfb6
Address Azure OpenAI review comments
4dd231f
Merge latest main into Azure OpenAI support
a0d1b1d
Merge remote-tracking branch 'origin/main' into feature/azure-openai-…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import { afterEach, describe, expect, it, vi } from "vitest"; | ||
|
|
||
| import { detectProviderForEnv } from "../src/config.js"; | ||
| import { createProvider } from "../src/providers/index.js"; | ||
|
|
||
| const ORIGINAL_OPENAI_KEY = process.env["OPENAI_API_KEY"]; | ||
| const ORIGINAL_AZURE_KEY = process.env["AZURE_OPENAI_API_KEY"]; | ||
| const ORIGINAL_OPENAI_BASE = process.env["OPENAI_BASE_URL"]; | ||
|
|
||
| describe("Azure OpenAI config detection", () => { | ||
| afterEach(() => { | ||
| if (ORIGINAL_OPENAI_KEY === undefined) delete process.env["OPENAI_API_KEY"]; | ||
| else process.env["OPENAI_API_KEY"] = ORIGINAL_OPENAI_KEY; | ||
| if (ORIGINAL_AZURE_KEY === undefined) delete process.env["AZURE_OPENAI_API_KEY"]; | ||
| else process.env["AZURE_OPENAI_API_KEY"] = ORIGINAL_AZURE_KEY; | ||
| if (ORIGINAL_OPENAI_BASE === undefined) delete process.env["OPENAI_BASE_URL"]; | ||
| else process.env["OPENAI_BASE_URL"] = ORIGINAL_OPENAI_BASE; | ||
| vi.restoreAllMocks(); | ||
| }); | ||
|
|
||
| it("uses Azure OpenAI endpoint and deployment as the OpenAI-compatible LLM provider", () => { | ||
| const provider = detectProviderForEnv({ | ||
| AZURE_OPENAI_API_KEY: "azure-key", | ||
| AZURE_OPENAI_ENDPOINT: "https://agentmemory.openai.azure.com/", | ||
| AZURE_OPENAI_DEPLOYMENT: "gpt-5.4-mini", | ||
| }); | ||
|
|
||
| expect(provider).toEqual({ | ||
| provider: "openai", | ||
| model: "gpt-5.4-mini", | ||
| maxTokens: 4096, | ||
| baseURL: "https://agentmemory.openai.azure.com", | ||
| }); | ||
| }); | ||
|
|
||
| it("supports a legacy Azure deployment base URL", () => { | ||
| const provider = detectProviderForEnv({ | ||
| AZURE_OPENAI_API_KEY: "azure-key", | ||
| AZURE_OPENAI_BASE_URL: | ||
| "https://agentmemory.openai.azure.com/openai/deployments/gpt-5.4-nano", | ||
| }); | ||
|
|
||
| expect(provider.provider).toBe("openai"); | ||
| expect(provider.model).toBe("gpt-5.4-nano"); | ||
| expect(provider.baseURL).toBe( | ||
| "https://agentmemory.openai.azure.com/openai/deployments/gpt-5.4-nano", | ||
| ); | ||
| }); | ||
|
|
||
| it("does not enable Azure OpenAI without a deployment", () => { | ||
| const provider = detectProviderForEnv({ | ||
| AZURE_OPENAI_API_KEY: "azure-key", | ||
| AZURE_OPENAI_ENDPOINT: "https://agentmemory.openai.azure.com", | ||
| }); | ||
|
|
||
| expect(provider.provider).toBe("noop"); | ||
| }); | ||
|
|
||
| it("uses the Azure key for Azure requests even when OPENAI_API_KEY is also set", async () => { | ||
| process.env["OPENAI_API_KEY"] = "public-openai-key"; | ||
| process.env["AZURE_OPENAI_API_KEY"] = "azure-openai-key"; | ||
| const config = detectProviderForEnv({ | ||
| OPENAI_API_KEY: "public-openai-key", | ||
| AZURE_OPENAI_API_KEY: "azure-openai-key", | ||
| AZURE_OPENAI_ENDPOINT: "https://agentmemory.openai.azure.com", | ||
| AZURE_OPENAI_DEPLOYMENT: "gpt-5.4-mini", | ||
| }); | ||
| let capturedHeaders = new Headers(); | ||
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| async (_url: string | URL | Request, init?: RequestInit) => { | ||
| capturedHeaders = new Headers(init?.headers); | ||
| return new Response( | ||
| JSON.stringify({ choices: [{ message: { content: "summary" } }] }), | ||
| { status: 200 }, | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| await createProvider(config).summarize("system", "user"); | ||
|
|
||
| expect(capturedHeaders.get("api-key")).toBe("azure-openai-key"); | ||
| expect(capturedHeaders.get("Authorization")).toBeNull(); | ||
| }); | ||
|
|
||
| it("uses the Azure key when OPENAI_BASE_URL points to Azure", async () => { | ||
| process.env["OPENAI_API_KEY"] = "public-openai-key"; | ||
| process.env["AZURE_OPENAI_API_KEY"] = "azure-openai-key"; | ||
| process.env["OPENAI_BASE_URL"] = "https://agentmemory.openai.azure.com"; | ||
| let capturedHeaders = new Headers(); | ||
| vi.spyOn(globalThis, "fetch").mockImplementation( | ||
| async (_url: string | URL | Request, init?: RequestInit) => { | ||
| capturedHeaders = new Headers(init?.headers); | ||
| return new Response( | ||
| JSON.stringify({ choices: [{ message: { content: "summary" } }] }), | ||
| { status: 200 }, | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| await createProvider({ | ||
| provider: "openai", | ||
| model: "gpt-5.4-mini", | ||
| maxTokens: 256, | ||
| }).summarize("system", "user"); | ||
|
|
||
| expect(capturedHeaders.get("api-key")).toBe("azure-openai-key"); | ||
| expect(capturedHeaders.get("Authorization")).toBeNull(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.