Open
Conversation
filiptibell
reviewed
Aug 27, 2024
Collaborator
filiptibell
left a comment
filiptibell
left a comment
There was a problem hiding this comment.
I'm not sure this PR really understands the linked issue it is supposed to be closing. Giving bare executables / artifacts without extensions the same priority in artifact selection as other formats will lead to errors in which artifact gets selected, especially if any artifact without a file extension is directly interpreted as an ELF binary.
Please take another look at both #4 and #7 which links the former.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7.
Would be nice to have some examples of tools other than sentry that also include bare executable releases for tests.