Allow disabling payload logging on non-200 status#487
Open
PoCTo wants to merge 1 commit intorollbar:masterfrom
Open
Allow disabling payload logging on non-200 status#487PoCTo wants to merge 1 commit intorollbar:masterfrom
PoCTo wants to merge 1 commit intorollbar:masterfrom
Conversation
… payload in logs when a non-200 status-code occurs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
#486
Added "log_payload_on_error" setting, to have ability to not log payloads even in case of non-200 codes received from the host. This addresses potential security issue of exposing access token in logs, as well as allows to not spam huge payloads locally.
Type of change
Related issues
#486
Checklists
Development
Code review