Support for SSH-1.99 SSH Identification String from Client#778
Merged
ronf merged 1 commit intoronf:developfrom Oct 23, 2025
Merged
Support for SSH-1.99 SSH Identification String from Client#778ronf merged 1 commit intoronf:developfrom
ronf merged 1 commit intoronf:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #778 +/- ##
===========================================
- Coverage 99.85% 99.83% -0.02%
===========================================
Files 95 100 +5
Lines 27784 31552 +3768
Branches 2908 3036 +128
===========================================
+ Hits 27743 31501 +3758
- Misses 38 45 +7
- Partials 3 6 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Given that RFC 4253 is nearly 20 years old at this point, I don't know how much value there is in continuing to support SSH 1.99 as an identification string. However, I don't see any real harm in it, so I've gone ahead and merged this change in the AsyncSSH "develop" branch. Thanks for your PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses #777 by dropping the
self.is_client()condition when checking forSSH-1.99in the protoversion, thereby allowing it to apply to both client and server instances.asyncssh/asyncssh/connection.py
Lines 1553 to 1554 in d281290