[RF] Remove all code related to constant term optimization - #21831
Merged
Conversation
guitargeek
force-pushed
the
const_optimize_removal
branch
from
April 8, 2026 09:47
36493d2 to
06fcbf7
Compare
Test Results 23 files 23 suites 3d 16h 5m 53s ⏱️ Results for commit 810f966. ♻️ This comment has been updated with latest results. |
guitargeek
force-pushed
the
const_optimize_removal
branch
from
April 12, 2026 14:56
06fcbf7 to
54f6ce7
Compare
guitargeek
force-pushed
the
const_optimize_removal
branch
from
April 26, 2026 16:30
54f6ce7 to
675508e
Compare
guitargeek
force-pushed
the
const_optimize_removal
branch
2 times, most recently
from
August 4, 2026 11:56
59bd32f to
423fb25
Compare
guitargeek
force-pushed
the
const_optimize_removal
branch
from
September 2, 2026 12:00
423fb25 to
2e6ee99
Compare
guitargeek
marked this pull request as ready for review
September 2, 2026 12:00
guitargeek
requested review from
bellenot,
couet,
dpiparo and
hageboeck
as code owners
September 2, 2026 12:00
guitargeek
force-pushed
the
const_optimize_removal
branch
from
September 2, 2026 12:01
2e6ee99 to
f5d3353
Compare
This is one of the most complicated aspects of RooFit, which was deprecated in 6.40 and scheduled for removal in 6.42. It amounted to over 1 percent of the RooFitCore source code, and is now superseded by the vectorized evaluation backend, which does the caching of vector buffers transparently in the RooFit evaluator.
guitargeek
force-pushed
the
const_optimize_removal
branch
from
September 2, 2026 12:04
f5d3353 to
810f966
Compare
guitargeek
changed the title
couet
removed their request for review
September 3, 2026 08:48
Member
|
Triggered final check with clean-build. |
dpiparo
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is one of the most complicated aspects of RooFit, which was deprecated in 6.40 and scheduled for removal in 6.42.
It amounted to over 1 percent of the RooFitCore source code, and is now superseded by the vectorized evaluation backend, which does the caching of vector buffers transparently in the RooFit evaluator.
Follows up on 7e94aef, where the feature got deprecated.