[core,RF,misc,interpreter] fix windows warning#22057
Merged
guitargeek merged 16 commits intoroot-project:masterfrom Apr 29, 2026
Merged
[core,RF,misc,interpreter] fix windows warning#22057guitargeek merged 16 commits intoroot-project:masterfrom
guitargeek merged 16 commits intoroot-project:masterfrom
Conversation
C:\ROOT-CI\src\roofit\roofitcore\src\RooLinkedList.cxx(71,19): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\ROOT-CI\build\roofit\roofitcore\RooFitCore.vcxproj]
Test Results 22 files 22 suites 3d 8h 45m 35s ⏱️ For more details on these failures, see this check. Results for commit b94e545. ♻️ This comment has been updated with latest results. |
Contributor
|
@ferdymercury, any reason that this PR is still marked as draft? It looks ready-to-merge for me! |
Collaborator
Author
|
There are more warnings in roofit/test (see win64 raw logs) but if you want these can go into separate PR. (Or feel free to take over this PR) |
warning C4326: return type of 'main' should be 'int' instead of 'void'
warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation
warning C4805: '|=': unsafe mix of type 'int' and type 'bool' in operation
warning C4804: '/': unsafe use of type 'bool' in operation
warning C4756: overflow in constant arithmetic
discarding return value of function with [[nodiscard]] attribute
ferdymercury
changed the title
ferdymercury
commented
Apr 27, 2026
ferdymercury
commented
Apr 27, 2026
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
ferdymercury
commented
Apr 27, 2026
ferdymercury
requested review from
bellenot,
dpiparo,
guitargeek,
lmoneta and
pcanal
as code owners
pcanal
reviewed
Apr 28, 2026
ferdymercury
commented
Apr 29, 2026
ferdymercury
commented
Apr 29, 2026
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C:\ROOT-CI\src\roofit\roofitcore\src\RooLinkedList.cxx(71,19): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\ROOT-CI\build\roofit\roofitcore\RooFitCore.vcxproj]
also warning about unused e var in TROOT
and several more.
Related: #22069