Skip to content

[gl] avoid crash with system libftgl #22101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ferdymercury wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −0
Open

[gl] avoid crash with system libftgl #22101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions graf3d/gl/src/TGLFontManager.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,15 @@ void TGLFont::RenderHelper(const Char *txt, Double_t x, Double_t y, Double_t ang
glPushMatrix();
//glLoadIdentity();

#ifndef BUILTIN_FTGL
// https://github.com/root-project/root/issues/22076#issuecomment-4342764706
char* vtxt = (char*)txt; // cast away const
const auto len = strlen(vtxt);
for(auto i = 0UL; i < len; ++i)
if (static_cast<unsigned char>(vtxt[i]) > static_cast<unsigned char>('\277'))
vtxt[i] = '\277';
#endif

// FTGL is not const correct.
Float_t llx = 0.f, lly = 0.f, llz = 0.f, urx = 0.f, ury = 0.f, urz = 0.f;
BBox(txt, llx, lly, llz, urx, ury, urz);
Expand Down
Loading