Skip to content

[ntuple] Remove deprecated overload of RField::SetQuantized #22108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silverweed wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −4
Open

[ntuple] Remove deprecated overload of RField::SetQuantized #22108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions tree/ntuple/inc/ROOT/RField/RFieldFundamental.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,9 +480,6 @@ public:
fValueMin = valueRange.first;
fValueMax = valueRange.second;
}

R__DEPRECATED(6, 42, "Use SetQuantized(std::size_t nBits, std::pair<T> valueRange) instead")
void SetQuantized(T minValue, T maxValue, std::size_t nBits) { SetQuantized(nBits, {minValue, maxValue}); }
};

template <>
Expand Down
2 changes: 1 addition & 1 deletion tutorials/io/ntuple/ntpl018_low_precision_floats.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ static void Write()
auto fieldReal32Quant = std::make_unique<ROOT::RField<float>>("myReal32Quant");
// Declare that this field will never store values outside of the [-1, 1] range (this will be checked dynamically)
// and that we want to dedicate 24 bits to this number on disk.
fieldReal32Quant->SetQuantized(-1., 1., 24);
fieldReal32Quant->SetQuantized(24, {-1., 1.});
model->AddField(std::move(fieldReal32Quant));
}

Expand Down
Loading