[df] Avoid relying on side-effect in test#22610
Open
vepadulano wants to merge 1 commit into
Open
Conversation
This commit touches the RNTupleWithGlobalRanges test in the RDatasetSpec suite with RNTuple. Previously, the test was checking a specific value returned after filtering the RNTuple dataset on specific 'rdfentry_' special column values. RDataFrame does not guarantee any ordering for the 'rdfentry_' column and in particular it does not guarantee correspondence between a specific value and the true global entry index in the input dataset. Now the test is enhanced to instead check that for each different specified global range RDataFrame retrieves the correct values from the dataset and that the 'rdfentry_' column values are unique across the different thread tasks.
vepadulano
force-pushed
the
df-test-avoid-side-effect
branch
from
17ead6e to
0548be6
Compare
Test Results 19 files 19 suites 2d 21h 0m 23s ⏱️ Results for commit 0548be6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit touches the RNTupleWithGlobalRanges test in the RDatasetSpec suite with RNTuple. Previously, the test was checking a specific value returned after filtering the RNTuple dataset on specific 'rdfentry_' special column values.
RDataFrame does not guarantee any ordering for the 'rdfentry_' column and in particular it does not guarantee correspondence between a specific value and the true global entry index in the input dataset.
Now the test is enhanced to instead check that for each different specified global range RDataFrame retrieves the correct values from the dataset and that the 'rdfentry_' column values are unique across the different thread tasks.
This is in preparation for a followup PR that reworks the RNTuple MT scheduling.