[hist] Test forwarding of Fill arguments#22613
Open
hahnjo wants to merge 1 commit into
Open
Conversation
They should not be copied, which might be expensive.
Test Results 22 files 22 suites 3d 11h 4m 37s ⏱️ For more details on these failures, see this check. Results for commit 09a2231. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should not be copied, which might be expensive.
For context: I paid attention to this during development, that's why all of the tests pass. The primary concern are
std::stringfor theRCategoricalAxisthat are only eventually cast tostd::string_view. During development ofRProfile(#22588), there is one tricky spot which may have copied arguments in my first implementation...