[cmake] set CMP0218 policy to NEW - #23219
Open
linev wants to merge 1 commit into
Open
Conversation
This exclude special handling for `CMAKE_WARN_DEPRECATED` and `CMAKE_ERROR_DEPRECATED` variables and suppress cmake 4.4 warnings when global list of all variables is scanned
guitargeek
approved these changes
Sep 1, 2026
guitargeek
left a comment
guitargeek
left a comment
Contributor
There was a problem hiding this comment.
LGTM! This is in line with the recommendation that projects should adopt the NEW behaviors as soon as they are compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exclude special handling for
CMAKE_WARN_DEPRECATEDandCMAKE_ERROR_DEPRECATEDvariables and suppress cmake 4.4 warnings when global list of all variables is scanned (line 602 of main CMakeLists.txt)