[core] rm GLconstants header unused since 19 years - #23256
Merged
Conversation
ferdymercury
marked this pull request as ready for review
September 4, 2026 11:19
pcanal
approved these changes
Sep 4, 2026
pcanal
left a comment
pcanal
left a comment
Member
There was a problem hiding this comment.
LGTM since it compiles without it ... butI am a bit confused on the history of this file ....
Test Results 23 files 23 suites 3d 20h 44m 8s ⏱️ For more details on these failures, see this check. Results for commit 76b594d. ♻️ This comment has been updated with latest results. |
ferdymercury
force-pushed
the
glconst
branch
from
September 5, 2026 05:55
d2a301e to
76b594d
Compare
ferdymercury
added
the
skip code analysis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unused since 5b2d3af#diff-1fd46cf1cbeb9bd1b82bafaf5f5c4db301e44aaf324ec7d11536f4959bda0d64