[cmake] modernize and simplify RConfigure generation - #23261
Draft
ferdymercury wants to merge 2 commits into
Draft
[cmake] modernize and simplify RConfigure generation#23261ferdymercury wants to merge 2 commits into
ferdymercury wants to merge 2 commits into
Conversation
Member
|
A slightly related issue ROOT-8061 |
Collaborator
Author
|
Unfortunately, for this to go forward, we need CMake 3.27 I will continue later on with RConfig.hxx that it has a lot of definitions that can be solved at config time and thus is movable to RConfigure.h. |
ferdymercury
added
skip code analysis
ferdymercury
force-pushed
the
rconfigmodern
branch
from
September 4, 2026 16:56
8aed3d4 to
d6304cb
Compare
Test Results 20 files 20 suites 3d 6h 12m 52s ⏱️ For more details on these failures, see this check. Results for commit a80d016. ♻️ This comment has been updated with latest results. |
inbuilt configure file and mention also current cplusplus not just ROOT in error message
ferdymercury
force-pushed
the
rconfigmodern
branch
from
September 5, 2026 22:20
84076bf to
a80d016
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This is a first step towards later using the defined target to remove dependencies with a global header file in some external / builtins targets, it's better to just depend on a config time target if one just needs the ROOT global defs.
Besides, 150 lines of boilerplate code are removed.
Checklist: