[RF] Convert stressRooFit tests to reference-free gtests - #23266
Merged
guitargeek merged 1 commit intoSep 6, 2026
Conversation
Convert 15 stressRooFit tests to google tests that validate against
analytic expectations, deterministic data, or self-consistency instead of
the hardcoded stressRooFit_ref.root file, following the precedent of the
rf705 conversion to testRooIntegralMorph. This way, expected numerical
changes can be distinguished from real regressions.
- rf110/rf308 (1D/2D normalization, createCdf), rf111 (numeric
integration config) and rf314 (parameterized-range fit): testRooAbsPdf
- rf302 (utility function composition): testRooAbsReal
- rf402 (dataset reduce/merge/append): testRooDataSet
- rf404-rf406 (Roo1DTable, category ranges, threshold/binning/mapped/
super/multi categories): testRooCategory
- rf109 (RooPlot::chiSquare, residHist, pullHist): testRooHist
- rf605 (RooProfileLL): new testRooProfileLL
- rf701-rf703 (RooEfficiency 1D/2D, RooEffProd): new testRooEfficiency
- rf704 (amplitude sum pdf): new testRooRealSumPdf
Several of these classes had no google test coverage at all before
(RooProfileLL, RooEfficiency, RooEffProd, the category mapping classes,
RooPlot residual/pull machinery, and dataset merge/append).
The fit-based conversions are parametrized over the RooFit evaluation
backends via a new shared fixture in gtest_wrapper.h, matching the
backend coverage of the removed stressRooFit invocations (including
codegen for the RooEfficiency fits, which skips only the RooEffProd case
that the stress suite also excluded). Tolerances for comparing results of
independent minimizations are kept at the scale of the Minuit convergence
criterion to avoid flakiness.
The converted tests are removed from the stressRooFit suite; the
corresponding entries in stressRooFit_ref.root are simply unused, so the
reference file does not need to be regenerated.
🤖 Done with the help of AI
Test Results 23 files 23 suites 3d 19h 12m 40s ⏱️ For more details on these failures, see this check. Results for commit 8087814. ♻️ This comment has been updated with latest results. |
dpiparo
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert 15 stressRooFit tests to google tests that validate against analytic expectations, deterministic data, or self-consistency instead of the hardcoded stressRooFit_ref.root file, following the precedent of the rf705 conversion to testRooIntegralMorph. This way, expected numerical changes can be distinguished from real regressions.
Several of these classes had no google test coverage at all before (RooProfileLL, RooEfficiency, RooEffProd, the category mapping classes, RooPlot residual/pull machinery, and dataset merge/append).
The fit-based conversions are parametrized over the RooFit evaluation backends via a new shared fixture in gtest_wrapper.h, matching the backend coverage of the removed stressRooFit invocations (including codegen for the RooEfficiency fits, which skips only the RooEffProd case that the stress suite also excluded). Tolerances for comparing results of independent minimizations are kept at the scale of the Minuit convergence criterion to avoid flakiness.
The converted tests are removed from the stressRooFit suite; the corresponding entries in stressRooFit_ref.root are simply unused, so the reference file does not need to be regenerated.
🤖 Done with the help of AI