[RF] Fix data span alignment in batch-mode RooUnbinnedL - #23267
Open
guitargeek wants to merge 1 commit into
Open
[RF] Fix data span alignment in batch-mode RooUnbinnedL#23267guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
The probabilities returned by the RooFit::Evaluator are indexed by the original event indices, aligned with the weights that are obtained from RooAbsData::getWeightBatch(). Skipping zero-weight events when creating the data spans misaligns the two arrays, resulting in NaNs when evaluating the likelihood of a binned dataset with empty bins. Zero-weight events are already skipped in the summation loop, so don't skip them when creating the data spans. This commit also adds a unit test that evaluates a batch-mode RooUnbinnedL on a binned dataset with empty bins, which catches the problem. 🤖 Done with the help of AI
Test Results 23 files 23 suites 3d 15h 28m 32s ⏱️ Results for commit 7551317. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The probabilities returned by the RooFit::Evaluator are indexed by the original event indices, aligned with the weights that are obtained from RooAbsData::getWeightBatch(). Skipping zero-weight events when creating the data spans misaligns the two arrays, resulting in NaNs when evaluating the likelihood of a binned dataset with empty bins.
Zero-weight events are already skipped in the summation loop, so don't skip them when creating the data spans.
This commit also adds a unit test that evaluates a batch-mode RooUnbinnedL on a binned dataset with empty bins, which catches the problem.
🤖 Done with the help of AI