This repository was archived by the owner on May 31, 2025. It is now read-only.
fix doTransform() for Eigen::Quaternion#496
Closed
gleichdick wants to merge 4 commits intoros:noetic-develfrom
Closed
fix doTransform() for Eigen::Quaternion#496gleichdick wants to merge 4 commits intoros:noetic-develfrom
gleichdick wants to merge 4 commits intoros:noetic-develfrom
Conversation
gleichdick
force-pushed
the
fix_doTransform
branch
from
cc1c6ee to
aefdc7b
Compare
gleichdick
force-pushed
the
fix_doTransform
branch
from
aefdc7b to
182a7ee
Compare
ooeygui
pushed a commit
to ms-iot/geometry2
that referenced
this pull request
Oct 12, 2022
* Export a tf2_geometry_msgs::tf2_geometry_msgs target Signed-off-by: Shane Loretz <sloretz@openrobotics.org> * Comment that tf2_ros is used but intentionally not linked Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
peci1
suggested changes
Apr 9, 2023
Contributor
peci1
left a comment
peci1
left a comment
There was a problem hiding this comment.
As this was merged into ROS 2, is there anything blocking this PR?
It seems to me tf2_ros is a test-only dependency, but it was added as <depend>. Could you change it to <test_depend> only, please? (and do according changes in CMakeLists)
Contributor
|
Thank you for the PR! ROS Noetic will reach end-of-life on May 31st, 2025. Every change comes with a risk of introducing regressions, and there isn't much time left to fix them. To make sure this PR doesn't introduce any regressions please:
|
Contributor
|
ROS 1 is end-of-life (EOL) as of today, May 31st 2025. I am archiving this repository because:
If you still rely on ROS 1, read this page to learn about your options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of ros2/geometry2#369