Conversation
clalancette
approved these changes
May 28, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good, will run CI on it next.
Contributor
|
CI:
|
Contributor
Author
|
Shoot, the MSVC error was actually one of my reasons to basically rewrite the whole |
Contributor
Instead of giving up on this whole thing, can we just comment out the problematic statements with a TODO note? That would still enable more of these tests, and also keep the size of #427 down. |
Contributor
Author
|
Okay, sounds reasonable to me. At least the stamped tests should work, because their convert functions don't exsists in the Eigen namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was separated from #368