Warning Message Intervals for canTransform#663
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
|
@tfoote or @clalancette fix looks good to me, but maybe there is a reason to continiously send these amount of messages. Thoughts? |
ahcorde
left a comment
There was a problem hiding this comment.
This is not compiling https://ci.ros2.org/job/ci_linux/20489/console
|
It seems the main error is in They are overrides of
The nice thing about removing the function parameter would be that functions like It's also a good time to ask if a default value of 5000ms (5 secs) is alright, I figured anything in the range of [2,8] was ok. |
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
|
I decided to go with option 2 as I felt option 3 was going to be more awkward, plus various other repositories set local values for |
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
|
@ros-pull-request-builder retest this please |
|
Real quick, does this PR resolve any of the pull requests or issues in the table in the original description? |
This PR is meant to prevent the spam of messages from the method
canTransform, while still remaining security, preventing an API break, and reducing load. There are a slew of issues and pull requests related to this problem:With all those pull requests looking very similar. Though, since the merging of #655 we have access to the macro
RCUTILS_LOG_WARN_THROTTLEwhich solves the caveat ofBy using a throttled version we can release warning messages every 5000 ms (currently the default), that way the messge can't be ignored by the user, but they won't annihilate the terminal.