Open
Conversation
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
Contributor
|
clalancette
approved these changes
Apr 9, 2024
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me with green CI.
Contributor
|
@CursedRock17 Oof, unfortunately MSVC thinks that we have an ambiguous overload here. Can you take a look? |
Contributor
Author
|
Sorry for the delay, so it looks like that ambigous functions call has been documented before in Pull Request #434. That solution continues to work even with clang, which was the main issues that we were having due to adl in other compilers. But we could also enable the
Either way I don't think we're getting around this because two phase lookup hasn't been diminished from MSVC and ADL will be the default on other compilers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is meant to solve this TODO in which convert needed to be added to complete the tests. The
convertfunction was added in PR #167, the test should pass.